fix: Do not panic if WebAuthn.dll is missing#36859
Merged
codingllama merged 2 commits intomasterfrom Jan 18, 2024
Merged
Conversation
Contributor
Author
|
Tested by changing the DLL name to something else (which gives me the exact same panic as #36851) and applying the fix. |
codingllama
commented
Jan 18, 2024
| // checkIfDLLExistsAndGetAPIVersionNumber checks if dll exists and tries to load | ||
| // it's version via API call. This function makes sure to not panic if dll is | ||
| // missing. | ||
| func checkIfDLLExistsAndGetAPIVersionNumber() (int, error) { |
Contributor
Author
There was a problem hiding this comment.
It was right in the func name too 🤦
Closed
ravicious
approved these changes
Jan 18, 2024
Member
ravicious
left a comment
ravicious
left a comment
There was a problem hiding this comment.
I can confirm that this fixes the issue on that Azure VM running Windows 10.
rosstimothy
approved these changes
Jan 18, 2024
public-teleport-github-review-bot
Bot
removed request for
bl-nero and
ryanclark
|
@codingllama See the table below for backport results.
|
This was referenced Jan 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a tsh panics on Windows if WebAuthn.dll is missing.
The regression was introduced by #34737.
#36851
Changelog: Fix tsh panic on Windows if WebAuthn.dll is missing